fix(web): avoid eval history crash when toolUses is null#4660
fix(web): avoid eval history crash when toolUses is null#4660pandego wants to merge 0 commit intogoogle:mainfrom
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Hi @pandego ,Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
|
Hi @wyf7107 , can you please review this. |
67459c2 to
d1241b4
Compare
d1241b4 to
00d791d
Compare
|
Refreshed this branch onto current The original change was targeting an older generated browser bundle file. I ported the null guard to the active bundle referenced by Validation run:
|
|
Refreshed this branch onto current The original fix was touching an older generated browser bundle file that no longer exists on Validation run:
|
00d791d to
1ee0623
Compare
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
Failed eval history entries can crash the web UI when
intermediateData.toolUsesis missing/null.formatToolUsescurrently iterates directly over that value and throwsTypeError: e is not iterable.Solution:
Add a null guard in
formatToolUsesso missingtoolUsesis treated as an empty list.Testing Plan
Unit Tests:
Passed locally:
.venv/bin/pytest tests/unittests/evaluation/test_eval_config.py7 passedManual End-to-End (E2E) Tests:
Not run in this environment. This patch is a minimal defensive guard on the affected formatter path.
Checklist
Additional context
This is intentionally minimal (1-line behavior change) to reduce risk and keep review focused.