Skip to content

fix(models): update 429 docs link for Gemini#4818

Open
ftnext wants to merge 3 commits intogoogle:mainfrom
ftnext:fix-429-doc-link
Open

fix(models): update 429 docs link for Gemini#4818
ftnext wants to merge 3 commits intogoogle:mainfrom
ftnext:fix-429-doc-link

Conversation

@ftnext
Copy link
Contributor

@ftnext ftnext commented Mar 13, 2026

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

2. Or, if no issue exists, describe the change:

Problem:
src/google/adk/models/google_llm.py includes a mitigation link for 429 RESOURCE_EXHAUSTED, but the current URL points to a broken docs anchor:
https://google.github.io/adk-docs/agents/models/#error-code-429-resource_exhausted
image

Solution:
Update the link to the current Gemini-specific docs page so users are directed to the correct troubleshooting section:
https://google.github.io/adk-docs/agents/models/google-gemini/#error-code-429-resource_exhausted
image

Testing Plan

This is a small string-only fix for a broken documentation link.
No unit tests were added because there does not appear to be existing test coverage for this message and the change does not affect runtime behavior beyond the emitted URL.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Confirmed the updated URL in the source points to the intended documentation page/anchor.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

This change only updates the documentation URL shown in the RESOURCE_EXHAUSTED guidance message.

@google-cla
Copy link

google-cla bot commented Mar 13, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where a documentation link within the google_llm.py file was broken. The change updates the URL to correctly point to the Gemini-specific mitigation guidance for the 429 RESOURCE_EXHAUSTED error, thereby improving the user experience and troubleshooting process for developers.

Highlights

  • Broken Documentation Link: The existing documentation link for the 429 RESOURCE_EXHAUSTED error mitigation in src/google/adk/models/google_llm.py was pointing to a broken anchor, leading users to an incorrect page.
  • Updated Link for Gemini: The documentation link has been updated to correctly direct users to the Gemini-specific troubleshooting section for the 429 RESOURCE_EXHAUSTED error, ensuring accurate guidance.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/google/adk/models/google_llm.py
    • Updated the URL for _RESOURCE_EXHAUSTED_POSSIBLE_FIX_MESSAGE to point to the correct Gemini documentation.
Activity
  • The author performed a self-review of the code changes.
  • The author confirmed reading the contribution guide.
  • The author manually tested the updated URL to ensure it points to the intended documentation page and anchor.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added the documentation [Component] This issue is related to documentation, it will be transferred to adk-docs label Mar 13, 2026
@adk-bot
Copy link
Collaborator

adk-bot commented Mar 13, 2026

Response from ADK Triaging Agent

Hello @ftnext, thank you for creating this PR!

In order to get this PR merged, you'll need to sign a Contributor License Agreement (CLA). You can find more information at https://cla.developers.google.com/.

Thanks!

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates a broken documentation link in an error message for 429 RESOURCE_EXHAUSTED errors. I've added a minor suggestion to improve the formatting of the multiline string to make the resulting error message more compact and readable.

Comment on lines 54 to 58
_RESOURCE_EXHAUSTED_POSSIBLE_FIX_MESSAGE = """
On how to mitigate this issue, please refer to:

https://google.github.io/adk-docs/agents/models/#error-code-429-resource_exhausted
https://google.github.io/adk-docs/agents/models/google-gemini/#error-code-429-resource_exhausted
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While you're updating the link, you could also improve the formatting of this multiline string to avoid excessive newlines in the final error message. The current definition adds a leading and trailing newline to the string. When combined with the \n\n in the f-string where it's used, this results in extra blank lines in the error output. Removing them will make the error message more compact.

_RESOURCE_EXHAUSTED_POSSIBLE_FIX_MESSAGE = """On how to mitigate this issue, please refer to:

https://google.github.io/adk-docs/agents/models/google-gemini/#error-code-429-resource_exhausted"""

@ftnext ftnext force-pushed the fix-429-doc-link branch from 40f6dc9 to 28addb5 Compare March 13, 2026 12:04
@rohityan rohityan self-assigned this Mar 13, 2026
@rohityan rohityan added the needs review [Status] The PR/issue is awaiting review from the maintainer label Mar 13, 2026
@rohityan
Copy link
Collaborator

Hi @ftnext , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share.

@rohityan
Copy link
Collaborator

Hi @wuliang229 , can you please review this. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation [Component] This issue is related to documentation, it will be transferred to adk-docs needs review [Status] The PR/issue is awaiting review from the maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants