fix(models): update 429 docs link for Gemini#4818
fix(models): update 429 docs link for Gemini#4818ftnext wants to merge 3 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where a documentation link within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Response from ADK Triaging Agent Hello @ftnext, thank you for creating this PR! In order to get this PR merged, you'll need to sign a Contributor License Agreement (CLA). You can find more information at https://cla.developers.google.com/. Thanks! |
There was a problem hiding this comment.
Code Review
This pull request correctly updates a broken documentation link in an error message for 429 RESOURCE_EXHAUSTED errors. I've added a minor suggestion to improve the formatting of the multiline string to make the resulting error message more compact and readable.
| _RESOURCE_EXHAUSTED_POSSIBLE_FIX_MESSAGE = """ | ||
| On how to mitigate this issue, please refer to: | ||
|
|
||
| https://google.github.io/adk-docs/agents/models/#error-code-429-resource_exhausted | ||
| https://google.github.io/adk-docs/agents/models/google-gemini/#error-code-429-resource_exhausted | ||
| """ |
There was a problem hiding this comment.
While you're updating the link, you could also improve the formatting of this multiline string to avoid excessive newlines in the final error message. The current definition adds a leading and trailing newline to the string. When combined with the \n\n in the f-string where it's used, this results in extra blank lines in the error output. Removing them will make the error message more compact.
_RESOURCE_EXHAUSTED_POSSIBLE_FIX_MESSAGE = """On how to mitigate this issue, please refer to:
https://google.github.io/adk-docs/agents/models/google-gemini/#error-code-429-resource_exhausted"""40f6dc9 to
28addb5
Compare
|
Hi @ftnext , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
|
Hi @wuliang229 , can you please review this. LGTM |
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
2. Or, if no issue exists, describe the change:
Problem:

src/google/adk/models/google_llm.pyincludes a mitigation link for429 RESOURCE_EXHAUSTED, but the current URL points to a broken docs anchor:https://google.github.io/adk-docs/agents/models/#error-code-429-resource_exhausted
Solution:

Update the link to the current Gemini-specific docs page so users are directed to the correct troubleshooting section:
https://google.github.io/adk-docs/agents/models/google-gemini/#error-code-429-resource_exhausted
Testing Plan
This is a small string-only fix for a broken documentation link.
No unit tests were added because there does not appear to be existing test coverage for this message and the change does not affect runtime behavior beyond the emitted URL.
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
Confirmed the updated URL in the source points to the intended documentation page/anchor.
Checklist
Additional context
This change only updates the documentation URL shown in the
RESOURCE_EXHAUSTEDguidance message.