Add FuzzTargetsCount index and error log for bad targets - #5397
Merged
Conversation
aakallam
approved these changes
Jul 29, 2026
aakallam
left a comment
Collaborator
There was a problem hiding this comment.
Starting with an alert and then removing it if it is too noisy sounds good to me
dylanjew
force-pushed
the
dylanj/bad-weights
branch
from
July 29, 2026 14:36
34d4936 to
961ab55
Compare
Collaborator
Author
I'll see if we can set up alerting based on the log, otherwise I'll just send another PR to add a Monarch metric if that turns out to be difficult. |
dylanjew
force-pushed
the
dylanj/bad-weights
branch
from
July 30, 2026 14:40
961ab55 to
694537a
Compare
ViniciustCosta
approved these changes
Jul 31, 2026
dylanjew
force-pushed
the
dylanj/bad-weights
branch
from
July 31, 2026 17:42
694537a to
21bcd63
Compare
ViniciustCosta
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
fuzz_task_outputhas an invalid fuzz target,FuzzTargetCount.count = 0. This can happen when there are no fuzz target binaries found, or the build is entirely broken.When this happens, no more fuzz tasks would be scheduled. We recover from this scenario by falling back to the default modifier when the
FuzzerJob.multiplierwould be 0:clusterfuzz/src/clusterfuzz/_internal/cron/fuzzer_and_job_weights.py
Lines 380 to 383 in f547870
This is a health signal, and we should monitor it properly. This PR adds an index so we can look these up, and a specific error we can track this with.
@aakallam, I'm not sure whether we want to set up a metric for an alert on this, because we're going to have very large dimensionality here and we can just scan the logs/Datastore for bad fuzz targets. But I'm open to just throwing a Monarch metric here if that's the easiest way to alert us that something is broken.
Related to b/537750310
Testing
I pushed this change onto dev