Skip to content

Migrate NumberTaskFragment to use TaskScreen Component#3650

Merged
shobhitagarwal1612 merged 3 commits intomasterfrom
number-task-compose
Apr 1, 2026
Merged

Migrate NumberTaskFragment to use TaskScreen Component#3650
shobhitagarwal1612 merged 3 commits intomasterfrom
number-task-compose

Conversation

@shobhitagarwal1612
Copy link
Copy Markdown
Member

Towards #3630

  • Introduce NumberTaskScreen Composable to handle the UI.
  • Update NumberTaskFragment to use createComposeView and render the new NumberTaskScreen.
  • Replace NumberTaskFragmentTest with NumberTaskScreenTest and add more coverage
Screen_recording_20260401_195708.webm

@andreia-ferreira PTAL?

- Extract number task UI logic from `NumberTaskFragment` into a new `NumberTaskScreen` Composable.
- Update `NumberTaskFragment` to use `createComposeView` and integrate with the new `NumberTaskScreen`.
- Implement `NumberTaskContent` for the core input field and `NumberTaskScreen` to handle the overall task layout, including header and footer actions.
- Migrate `NumberTaskFragmentTest` to `NumberTaskScreenTest` using `ComposeContentTestRule` for more robust UI testing.
- Standardize task header icons by using `ic_question_answer` for number tasks.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.89%. Comparing base (e6ca258) to head (043afe5).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../datacollection/tasks/number/NumberTaskFragment.kt 0.00% 5 Missing ⚠️
...ui/datacollection/tasks/number/NumberTaskScreen.kt 82.60% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3650      +/-   ##
============================================
- Coverage     66.94%   66.89%   -0.06%     
+ Complexity     1639     1633       -6     
============================================
  Files           359      360       +1     
  Lines          8867     8886      +19     
  Branches       1137     1140       +3     
============================================
+ Hits           5936     5944       +8     
- Misses         2287     2297      +10     
- Partials        644      645       +1     
Files with missing lines Coverage Δ
...ui/datacollection/tasks/number/NumberTaskScreen.kt 82.60% <82.60%> (ø)
.../datacollection/tasks/number/NumberTaskFragment.kt 0.00% <0.00%> (-90.00%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shobhitagarwal1612 shobhitagarwal1612 merged commit d536155 into master Apr 1, 2026
8 of 9 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the number-task-compose branch April 1, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants