Migrate NumberTaskFragment to use TaskScreen Component#3650
Merged
shobhitagarwal1612 merged 3 commits intomasterfrom Apr 1, 2026
Merged
Migrate NumberTaskFragment to use TaskScreen Component#3650shobhitagarwal1612 merged 3 commits intomasterfrom
shobhitagarwal1612 merged 3 commits intomasterfrom
Conversation
- Extract number task UI logic from `NumberTaskFragment` into a new `NumberTaskScreen` Composable. - Update `NumberTaskFragment` to use `createComposeView` and integrate with the new `NumberTaskScreen`. - Implement `NumberTaskContent` for the core input field and `NumberTaskScreen` to handle the overall task layout, including header and footer actions. - Migrate `NumberTaskFragmentTest` to `NumberTaskScreenTest` using `ComposeContentTestRule` for more robust UI testing. - Standardize task header icons by using `ic_question_answer` for number tasks.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3650 +/- ##
============================================
- Coverage 66.94% 66.89% -0.06%
+ Complexity 1639 1633 -6
============================================
Files 359 360 +1
Lines 8867 8886 +19
Branches 1137 1140 +3
============================================
+ Hits 5936 5944 +8
- Misses 2287 2297 +10
- Partials 644 645 +1
🚀 New features to boost your workflow:
|
andreia-ferreira
approved these changes
Apr 1, 2026
app/src/main/java/org/groundplatform/android/ui/datacollection/tasks/number/NumberTaskScreen.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3630
NumberTaskScreenComposable to handle the UI.NumberTaskFragmentto usecreateComposeViewand render the newNumberTaskScreen.NumberTaskFragmentTestwithNumberTaskScreenTestand add more coverageScreen_recording_20260401_195708.webm
@andreia-ferreira PTAL?