Skip to content

Remove old unused GWT dependency#3056

Open
gbrodman wants to merge 1 commit into
google:masterfrom
gbrodman:removeGwt
Open

Remove old unused GWT dependency#3056
gbrodman wants to merge 1 commit into
google:masterfrom
gbrodman:removeGwt

Conversation

@gbrodman
Copy link
Copy Markdown
Collaborator

@gbrodman gbrodman commented May 20, 2026

This change is Reviewable

github-actions[bot]

This comment was marked as resolved.

@jicelhay
Copy link
Copy Markdown
Collaborator

console-webapp/package-lock.json line 631 at r1 (raw file):

      }
    },
    "node_modules/@angular/build/node_modules/@types/node": {

just noting that this seems to also be deleting console dependendencies that don't seem to be gwt.

Copy link
Copy Markdown
Collaborator

@jicelhay jicelhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jicelhay reviewed 11 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on gbrodman).

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Attention Required: Lockfile Detected

This pull request contains modifications to one or more *.lockfile files. Please confirm that you have run update_dependency.sh to push new dependencies to the private repo.

Someone with Admin role must manually dismiss this review before merging.

Copy link
Copy Markdown
Collaborator Author

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman made 1 comment.
Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion (waiting on jicelhay).


console-webapp/package-lock.json line 631 at r1 (raw file):

Previously, jicelhay (Juan Celhay) wrote…

just noting that this seems to also be deleting console dependendencies that don't seem to be gwt.

yeah AI loves to regenerate the package-lock.json file and either add or remove a bunch of stuff almost at random even though we've told it not to do that. Reverted -- it only removed some dependencies that are probably not used, so it probably wouldn't have mattered regardless

Copy link
Copy Markdown
Collaborator

@jicelhay jicelhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jicelhay reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on gbrodman).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants