Remove old unused GWT dependency#3056
Conversation
|
just noting that this seems to also be deleting console dependendencies that don't seem to be gwt. |
jicelhay
left a comment
There was a problem hiding this comment.
@jicelhay reviewed 11 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on gbrodman).
There was a problem hiding this comment.
⚠️ Attention Required: Lockfile Detected
This pull request contains modifications to one or more *.lockfile files. Please confirm that you have run update_dependency.sh to push new dependencies to the private repo.
Someone with Admin role must manually dismiss this review before merging.
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman made 1 comment.
Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion (waiting on jicelhay).
console-webapp/package-lock.json line 631 at r1 (raw file):
Previously, jicelhay (Juan Celhay) wrote…
just noting that this seems to also be deleting console dependendencies that don't seem to be gwt.
yeah AI loves to regenerate the package-lock.json file and either add or remove a bunch of stuff almost at random even though we've told it not to do that. Reverted -- it only removed some dependencies that are probably not used, so it probably wouldn't have mattered regardless
jicelhay
left a comment
There was a problem hiding this comment.
@jicelhay reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
This change is