Skip to content

fix: patch CWE-78 in console_io.py #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yabets4 wants to merge 1 commit into from
+2 −1
Closed

fix: patch CWE-78 in console_io.py #669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fire/console/console_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"""General console printing utilities used by the Cloud SDK."""

import os
import shlex
import signal
import subprocess
import sys
Expand Down Expand Up @@ -97,7 +98,7 @@ def More(contents, out, prompt=None, check_pager=True):
# Ignore SIGINT while the pager is running.
# We don't want to terminate the parent while the child is still alive.
signal.signal(signal.SIGINT, signal.SIG_IGN)
p = subprocess.Popen(pager, stdin=subprocess.PIPE, shell=True)
p = subprocess.Popen(shlex.split(pager), stdin=subprocess.PIPE)
enc = console_attr.GetConsoleAttr().GetEncoding()
p.communicate(input=contents.encode(enc))
p.wait()
Expand Down