Skip to content

Add timing logs to transfer_state. #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add timing logs to transfer_state. #764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion tunix/generate/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import logging
import math
import re
import time
from typing import Any, Dict, Iterator, List, Optional, Tuple

from flax import nnx
Expand Down Expand Up @@ -637,6 +638,7 @@ def transfer_state_with_mappings(
Returns:
The target state with the transferred values.
"""
start_time = time.time() # start time for weight conversion
# Get flat target state
tgt_flat_list = dst_state.flat_state()
# Build sharding dictionary if resharding is needed
Expand Down Expand Up @@ -699,7 +701,17 @@ def transfer_state_with_mappings(
else:
tgt_param = resharded_values_flat_dict[tgt_key]

return dst_state.from_flat_path(tgt_flat_list)
logging.info(
'Weight conversion to VLLM format took %s seconds',
time.time() - start_time,
)

transfer_start_time = time.time()
transferred_state = dst_state.from_flat_path(tgt_flat_list)
logging.info(
'Transferring state took %s seconds', time.time() - transfer_start_time
)
return transferred_state


def verify_state_closeness(golden_state, state, atol=1e-2):
Expand Down