tests: update repo location for core deps#2566
Conversation
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the source repository URLs for Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request correctly updates the repository locations for google-api-core and proto-plus in the noxfile configurations by modifying the gapic/templates/noxfile.py.j2 template. However, several noxfile.py files within the tests/integration/goldens directories, which appear to be generated, have also been directly modified. According to the repository's general rules, fixes for generated code should be applied solely to the generator templates to ensure consistency across the codebase. These generated files should be updated by regenerating them after the template modification, rather than through direct edits.
This PR is needed to update the `core_deps_from_source` nox session to point to the new location for `google-api-core` in the monorepo https://github.com/googleapis/google-cloud-python/tree/main/packages/google-api-core https://github.com/googleapis/google-cloud-python/blob/edd2b7ae39899124747ff62769287f4458387e0c/packages/google-apps-meet/noxfile.py#L600 See googleapis/gapic-generator-python#2566
https://github.com/googleapis/python-api-core has moved to https://github.com/googleapis/google-cloud-python/tree/main/packages/google-api-core
https://github.com/googleapis/proto-plus-python has moved to https://github.com/googleapis/google-cloud-python/tree/main/packages/proto-plus