Skip to content

Comments

tests: update repo location for core deps#2566

Merged
parthea merged 3 commits intomainfrom
update-repo-location
Feb 19, 2026
Merged

tests: update repo location for core deps#2566
parthea merged 3 commits intomainfrom
update-repo-location

Conversation

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 19, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the source repository URLs for google-api-core and proto-plus within various Nox test configuration files. These changes are necessary because both dependencies have migrated into the google-cloud-python monorepository, ensuring that development and integration tests correctly fetch the latest versions from their new locations.

Highlights

  • Dependency Repository Updates: The repository location for google-api-core has been updated to reflect its move into the google-cloud-python monorepo.
  • Dependency Repository Updates: The repository location for proto-plus has been updated to reflect its move into the google-cloud-python monorepo.
Changelog
  • gapic/templates/noxfile.py.j2
    • Updated the git URL for google-api-core to point to its new location within the google-cloud-python monorepo.
    • Updated the git URL for proto-plus to point to its new location within the google-cloud-python monorepo.
  • tests/integration/goldens/asset/noxfile.py
    • Updated the git URL for google-api-core to point to its new location within the google-cloud-python monorepo.
    • Updated the git URL for proto-plus to point to its new location within the google-cloud-python monorepo.
  • tests/integration/goldens/credentials/noxfile.py
    • Updated the git URL for google-api-core to point to its new location within the google-cloud-python monorepo.
    • Updated the git URL for proto-plus to point to its new location within the google-cloud-python monorepo.
  • tests/integration/goldens/eventarc/noxfile.py
    • Updated the git URL for google-api-core to point to its new location within the google-cloud-python monorepo.
    • Updated the git URL for proto-plus to point to its new location within the google-cloud-python monorepo.
  • tests/integration/goldens/logging/noxfile.py
    • Updated the git URL for google-api-core to point to its new location within the google-cloud-python monorepo.
    • Updated the git URL for proto-plus to point to its new location within the google-cloud-python monorepo.
  • tests/integration/goldens/logging_internal/noxfile.py
    • Updated the git URL for google-api-core to point to its new location within the google-cloud-python monorepo.
    • Updated the git URL for proto-plus to point to its new location within the google-cloud-python monorepo.
  • tests/integration/goldens/redis/noxfile.py
    • Updated the git URL for google-api-core to point to its new location within the google-cloud-python monorepo.
    • Updated the git URL for proto-plus to point to its new location within the google-cloud-python monorepo.
  • tests/integration/goldens/redis_selective/noxfile.py
    • Updated the git URL for google-api-core to point to its new location within the google-cloud-python monorepo.
    • Updated the git URL for proto-plus to point to its new location within the google-cloud-python monorepo.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly updates the repository locations for google-api-core and proto-plus in the noxfile configurations by modifying the gapic/templates/noxfile.py.j2 template. However, several noxfile.py files within the tests/integration/goldens directories, which appear to be generated, have also been directly modified. According to the repository's general rules, fixes for generated code should be applied solely to the generator templates to ensure consistency across the codebase. These generated files should be updated by regenerating them after the template modification, rather than through direct edits.

@parthea parthea marked this pull request as ready for review February 19, 2026 18:31
@parthea parthea requested a review from a team as a code owner February 19, 2026 18:31
@parthea parthea merged commit d15f5fa into main Feb 19, 2026
140 checks passed
@parthea parthea deleted the update-repo-location branch February 19, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants