surface errors: add fix for compliance #614
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x-php into surface-errors-betterbrent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix the issues from GAPIC Showcase where Rest and gRPC return different error details.
See @gapic-generator-php/tests/Conformance/ShowcaseTest.php
Also see https://google.aip.dev/193
Is it okay to hardcode
grpc-status-details-bin?(this seems to be OK, according to protobuf README), but I still don't understand how
grpc-status-details-binworks. For PHP this is wheregoogle.rpc.Statusmessage is encoded. I am guessing it gets thrown into the error response (which is a PHP Standard Object, and NOT a protobuf message) because it wants to provide an error message that ISN'T a protobuf message (in case that class doesn't exist).There's still ONE detail that I haven't found documented anywhere, which is, the
grpc-status-details-binis an ARRAY... so does that mean there can be multiple statuses returned in an error?