fix(storage): Use append_object_spec in EnrichSpan for ResumeAppendableUpload - #16296
Merged
Conversation
… name from append_object_spec rather than write_object_spec
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ResumeAppendableObjectUpload method in AsyncConnectionTracing to extract the bucket name from p.request.append_object_spec().bucket() instead of p.request.write_object_spec().resource().bucket(). Additionally, the corresponding unit test ResumeAppendableObjectUploadSuccess is updated to initialize and pass a BidiWriteObjectRequest with the append object spec bucket configured. There are no review comments, so I have no feedback to provide.
bajajneha27
marked this pull request as ready for review
July 30, 2026 10:17
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16296 +/- ##
==========================================
- Coverage 92.31% 92.30% -0.01%
==========================================
Files 2223 2223
Lines 208086 208087 +1
==========================================
- Hits 192086 192084 -2
- Misses 16000 16003 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kalragauri
approved these changes
Jul 30, 2026
bajajneha27
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.