fix(pubsub): avoid deadlock by ensuring lease refresh timer runs on cq thread - #16297
fix(pubsub): avoid deadlock by ensuring lease refresh timer runs on cq thread#16297scotthart wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request addresses a self-deadlock issue in SubscriptionLeaseManagement::StartRefreshTimer by dispatching the lease refresh-timer continuation asynchronously via cq_.RunAsync instead of running it inline. This ensures that OnRefreshTimer always runs on a CompletionQueue thread without holding the mu_ lock. The associated unit tests have been updated to handle the deferred execution, and a new regression test has been added to verify this behavior. I have no feedback to provide.
c8deb2b to
a34b01f
Compare
a34b01f to
3123f01
Compare
|
Resubmission of #16250 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16297 +/- ##
=======================================
Coverage 92.31% 92.31%
=======================================
Files 2223 2223
Lines 208086 208128 +42
=======================================
+ Hits 192086 192131 +45
+ Misses 16000 15997 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.