Skip to content

fix: enable google-cloud-discoveryengine tests to run on windows#7302

Merged
pearigee merged 4 commits intomainfrom
pearigee-discoveryengine-windows-fix
Feb 27, 2026
Merged

fix: enable google-cloud-discoveryengine tests to run on windows#7302
pearigee merged 4 commits intomainfrom
pearigee-discoveryengine-windows-fix

Conversation

@pearigee
Copy link
Contributor

@pearigee pearigee commented Feb 25, 2026

The fix uses the bash || syntax to try the first request and on failure try the second one.

That way, if on *nix operating systems the first block will succeed. On Windows, the second block will be executed instead using the alternate syntax for setting environment variables.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #7297 🦕

@pearigee pearigee requested a review from a team as a code owner February 25, 2026 18:13
@pearigee pearigee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2026
@pearigee pearigee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2026
@pearigee pearigee merged commit a28d23f into main Feb 27, 2026
23 of 26 checks passed
@pearigee pearigee deleted the pearigee-discoveryengine-windows-fix branch February 27, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

discoveryengine package unit tests fail on windows.

3 participants