feat(o11y): regenerate client libraries with consolidated LroRecorder#5804
Draft
haphungw wants to merge 2 commits into
Draft
feat(o11y): regenerate client libraries with consolidated LroRecorder#5804haphungw wants to merge 2 commits into
LroRecorder#5804haphungw wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the long-running operation (LRO) tracing implementation by removing the task-local POLL_ATTEMPT_COUNT and consolidating the polling attempt count directly into an immutable, thread-safe LroRecorder struct. The LroRecorder now supports copy-on-write context propagation via with_attempt_count, and all generated service tracing files have been updated to retrieve the attempt count from the current LroRecorder context. I have no further feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5804 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 226 226
Lines 57514 57514
=======================================
+ Hits 56302 56303 +1
+ Misses 1212 1211 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
haphungw
added a commit
to googleapis/librarian
that referenced
this pull request
Jun 4, 2026
…tor (#6259) Update the template to generate code using our new consolidated `LroRecorder` API (googleapis/google-cloud-rust#5803). Instead of querying the separated `POLL_ATTEMPT_COUNT` task-local directly, the telemetry stubs will now query the active recorder. Staged @ googleapis/google-cloud-rust#5804 Follow up 2 for googleapis/google-cloud-rust#5695
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerate using the updated librarian template (googleapis/librarian#6259). Telemetry decorator stubs now propagate and query the consolidated
LroRecordercontext directly.