Skip to content

impl(bigquery): add client builder#5869

Merged
alvarowolfx merged 9 commits into
googleapis:mainfrom
alvarowolfx:impl-bq-client-builder
Jun 11, 2026
Merged

impl(bigquery): add client builder#5869
alvarowolfx merged 9 commits into
googleapis:mainfrom
alvarowolfx:impl-bq-client-builder

Conversation

@alvarowolfx

Copy link
Copy Markdown
Contributor

Towards #5844

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Jun 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a high-level BigQuery client and its associated ClientBuilder to configure service endpoints, credentials, and retry policies. The feedback recommends removing unused code and configurations, specifically the #[allow(dead_code)] attribute on job_service and the unused storage_endpoint field, to align with repository guidelines against introducing incomplete features.

Comment thread src/bigquery/src/client.rs
Comment thread src/bigquery/src/client_builder.rs Outdated
@alvarowolfx alvarowolfx marked this pull request as ready for review June 10, 2026 19:32
@alvarowolfx alvarowolfx requested a review from a team as a code owner June 10, 2026 19:32
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.47619% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.88%. Comparing base (8603f7d) to head (53c8e65).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/bigquery/src/client.rs 85.71% 5 Missing ⚠️
src/bigquery/src/client_builder.rs 93.87% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5869      +/-   ##
==========================================
- Coverage   97.89%   97.88%   -0.02%     
==========================================
  Files         227      229       +2     
  Lines       57992    58076      +84     
==========================================
+ Hits        56774    56849      +75     
- Misses       1218     1227       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/bigquery/src/client.rs Outdated
Comment thread src/bigquery/src/client_builder.rs Outdated
Comment thread src/bigquery/src/client_builder.rs Outdated
Comment thread src/bigquery/src/client.rs Outdated
@alvarowolfx alvarowolfx merged commit 83e24b6 into googleapis:main Jun 11, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants