Skip to content

feat(o11y): propagate LRO destination ID to child spans#5871

Open
haphungw wants to merge 1 commit into
googleapis:mainfrom
haphungw:feat-lro-propagate-resource-id
Open

feat(o11y): propagate LRO destination ID to child spans#5871
haphungw wants to merge 1 commit into
googleapis:mainfrom
haphungw:feat-lro-propagate-resource-id

Conversation

@haphungw

Copy link
Copy Markdown
Contributor

Introduce stateful propagation of the LRO destination ID (resource ID/operation name) across LRO polling attempts inside google-cloud-lro.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces tracking and recording of the destination ID for long-running operations (LRO) within LroRecorder by adding a thread-safe destination_id field, implementing helper methods, updating the polling attributes macro, and adding corresponding tests. The review feedback recommends simplifying the implementation by replacing std::sync::RwLock with std::sync::Mutex for the destination_id field, which aligns with the repository's style guide to avoid unnecessary complexity.

Comment thread src/lro/src/internal/tracing.rs Outdated
Comment thread src/lro/src/internal/tracing.rs Outdated
Comment thread src/lro/src/internal/tracing.rs Outdated
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.88%. Comparing base (094bf6d) to head (c9a339a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5871      +/-   ##
==========================================
- Coverage   97.89%   97.88%   -0.01%     
==========================================
  Files         227      227              
  Lines       57995    57995              
==========================================
- Hits        56774    56770       -4     
- Misses       1221     1225       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haphungw haphungw force-pushed the feat-lro-propagate-resource-id branch from 0eb02c1 to c9a339a Compare June 10, 2026 21:58
@haphungw haphungw marked this pull request as ready for review June 10, 2026 22:00
@haphungw haphungw requested a review from a team as a code owner June 10, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant