Skip to content

feat: raise InvalidGQLGenerationError on error with intermediate steps included#175

Merged
averikitsch merged 2 commits intogoogleapis:mainfrom
jordimas:issue_168
Jul 22, 2025
Merged

feat: raise InvalidGQLGenerationError on error with intermediate steps included#175
averikitsch merged 2 commits intogoogleapis:mainfrom
jordimas:issue_168

Conversation

@jordimas
Copy link
Copy Markdown
Contributor

@jordimas jordimas commented May 7, 2025

Fixes #168 by using a new exception type on GQL generation error

@jordimas jordimas requested review from a team May 7, 2025 12:08
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/langchain-google-spanner-python API. label May 7, 2025
@jordi-mas-dj
Copy link
Copy Markdown

cc: @mtyin

Copy link
Copy Markdown
Contributor

@mtyin mtyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jordi-mas-dj
Copy link
Copy Markdown

Rewrote commit message to pass Conventional Commits

averikitsch
averikitsch previously approved these changes May 13, 2025
@averikitsch
Copy link
Copy Markdown
Collaborator

/gcbrun

1 similar comment
@mtyin
Copy link
Copy Markdown
Contributor

mtyin commented May 22, 2025

/gcbrun

@mtyin
Copy link
Copy Markdown
Contributor

mtyin commented May 23, 2025

@jordi-mas-dj can you update the PR title so that the last remaining check can pass?

@jordimas jordimas changed the title On error, raise InvalidGQLGenerationError which includes intermediatesteps feat: raise InvalidGQLGenerationError on error with intermediate steps included May 24, 2025
@jordimas
Copy link
Copy Markdown
Contributor Author

@jordi-mas-dj can you update the PR title so that the last remaining check can pass?

Done, thanks

@averikitsch
Copy link
Copy Markdown
Collaborator

/gcbrun

@averikitsch
Copy link
Copy Markdown
Collaborator

/gcbrun

@averikitsch averikitsch merged commit 22f2158 into googleapis:main Jul 22, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/langchain-google-spanner-python API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

intermediate_steps not returned on exceptions

6 participants