Skip to content

Conversation

@daniel-sanche
Copy link
Contributor

Mypy tests are are currently failing, due to a combination of a typing change in the auth library, and the deprecation of Python 3.7

This PR fixes mypy, and makes the types a bit more explicit

@daniel-sanche daniel-sanche requested review from a team as code owners January 8, 2026 21:24
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 8, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses and resolves Mypy test failures by updating the Mypy configuration to target a newer Python version (3.14) and refining how authentication scopes are passed to the google.auth library. These changes ensure type checks are compatible with recent library updates and Python version deprecations, leading to a more robust and explicitly typed codebase.

Highlights

  • Mypy Configuration Update: The target Python version for Mypy checks has been updated from 3.7 to 3.14 in pyproject.toml, reflecting the deprecation of Python 3.7.
  • Credential Argument Handling: The google.auth.load_credentials_from_file and google.auth.default calls in google/api_core/operations_v1/transports/base.py now explicitly pass scopes and default_scopes arguments, removing the use of a scopes_kwargs dictionary. This makes the type handling more explicit.
  • Dependency Cleanup: The Python 3.7 specific types-mock dependency has been removed from the noxfile.py Mypy session, aligning with the updated Python version support.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses the mypy failures by updating the code to be more explicit with type hints and removing configurations related to the deprecated Python 3.7. The changes in google/api_core/operations_v1/transports/base.py to explicitly pass arguments to google.auth functions are a good improvement for type checking and readability. The updates to noxfile.py and pyproject.toml are also correct and align with the project's supported Python versions. Overall, the changes are clean, targeted, and well-justified.

@daniel-sanche daniel-sanche merged commit 0fe0632 into main Jan 8, 2026
20 of 21 checks passed
@daniel-sanche daniel-sanche deleted the fix_mypy branch January 8, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants