Fix SDLPrinter to include operation type for queries with variables#407
Merged
Fix SDLPrinter to include operation type for queries with variables#407
Conversation
gao-artur
approved these changes
Feb 2, 2026
Contributor
|
I think you added it to a wrong milestone |
Contributor
Oh, it's a parser repo. Nevermind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue in
SDLPrinterwhere anonymous query operations with variables were not printing thequerykeyword.According to the GraphQL specification, when an operation includes variable definitions, the operation type must be explicitly declared even for query operations without a name.
Changes
VisitOperationDefinitionAsyncto check ifVariablesis present in addition to checking for operation name or non-query operation typeSDLPrinterFromParsedTextTeststo verify the fix handles anonymous queries with variables correctlyExample
Before:
After: