Use equality instead of identity for enum value comparison#1602
Open
Hassad674 wants to merge 1 commit intographql-python:masterfrom
Open
Use equality instead of identity for enum value comparison#1602Hassad674 wants to merge 1 commit intographql-python:masterfrom
Hassad674 wants to merge 1 commit intographql-python:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1524
eq_enum was using 'is' (identity) to compare enum values with other objects. This works for interned strings but fails for dynamically constructed strings since Python doesn't guarantee string interning. Changed to '==' (equality) while adding a guard for cross-enum comparisons so different enum types with the same underlying value still compare as not equal.
Added a test that constructs a non-interned string to verify the equality works correctly.