Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion graphene/validation/depth_limit.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,11 @@ def determine_depth(
)
)
elif isinstance(node, FragmentSpreadNode):
fragment = fragments.get(node.name.value)
if fragment is None:
return 0
return determine_depth(
node=fragments[node.name.value],
node=fragment,
fragments=fragments,
depth_so_far=depth_so_far,
max_depth=max_depth,
Expand Down
13 changes: 13 additions & 0 deletions graphene/validation/tests/test_depth_limit_validator.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,19 @@ def test_should_ignore_field():
assert result == expected


def test_undefined_fragment_does_not_crash():
query = """
query read1 {
user {
name
...undefinedFragment
}
}
"""
errors, result = run_query(query, 10)
assert result == {"read1": 1}


def test_should_raise_invalid_ignore():
query = """
query read1 {
Expand Down