GAP-33: A proposal for Set-semantic compatible Type System Definitions#33
Merged
Conversation
eef916b to
893b04a
Compare
magicmark
reviewed
May 16, 2026
magicmark
reviewed
May 16, 2026
…es, will need to make more robust later
Contributor
|
Merging per
|
Contributor
|
@mjmahone heads up I added a newline to fix the build: |
Contributor
Author
|
Thanks @magicmark ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been working on a lot of operations that benefit from treating the GraphQL Schema as a Set. For context, see changes in the Relay schema-set crate: https://github.com/facebook/relay/tree/main/compiler/crates/schema-set
One of the core issues is there's no syntax I can use to get partial sets. For example I can have a type-definition and field definition removed, but there is still an argument on the field present.
This proposes to solve that through syntax that looks like:
We could get into this state if we did something like:
exclude
This proposal should give a syntax that we could use in @egoodwinx's proposal in #4