Conversation
There was a problem hiding this comment.
It's been a little while since we ran make generate, slight changes to the npm metadata file
| gl.delete_detector(fake_detector_id) # type: ignore | ||
|
|
||
|
|
||
| def test_create_detector_with_invalid_priming_group_id(gl: Groundlight): |
There was a problem hiding this comment.
no happy path test is strange.
| the detector (limited to 1KB). This metadata can be used to store additional | ||
| information like location, purpose, or related system IDs. You can retrieve this | ||
| metadata later by calling `get_detector()`. | ||
| :param priming_group_id: Optional ID of an existing PrimingGroup to associate with this detector. |
There was a problem hiding this comment.
We should callout that a 3rd party won't know what valid ones are and not to use it.
| metadata later by calling `get_detector()`. | ||
| :param class_names: The name or names of the class to use for the detector. Only used for multi-class | ||
| and counting detectors. | ||
| :param priming_group_id: Optional ID of an existing PrimingGroup to associate with this detector. |
There was a problem hiding this comment.
We should callout that a 3rd party won't know what valid ones are and not to use it.
| the detector (limited to 1KB). This metadata can be used to store additional | ||
| information like location, purpose, or related system IDs. You can retrieve this | ||
| metadata later by calling `get_detector()`. | ||
| :param priming_group_id: Optional ID of an existing PrimingGroup to associate with this detector. |
There was a problem hiding this comment.
We should callout that a 3rd party won't know what valid ones are and not to use it.
| the detector (limited to 1KB). This metadata can be used to store additional | ||
| information like location, purpose, or related system IDs. You can retrieve this | ||
| metadata later by calling `get_detector()`. | ||
| :param priming_group_id: Optional ID of an existing PrimingGroup to associate with this detector. |
There was a problem hiding this comment.
We should callout that a 3rd party won't know what valid ones are and not to use it.
sunildkumar
left a comment
sunildkumar
left a comment
There was a problem hiding this comment.
approved without conviction, as discussed on slack.
2 participants
Users can now create detectors belonging to a specific detector priming group with a known priming group id. Detectors in these groups will be able to start with a Groundlight defined pretrained model that is well suited for the task the priming group is built around