Skip to content

core: Test binary header base64 padding #12903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
perepeli wants to merge 1 commit into
base: master
Choose a base branch
from
Open

core: Test binary header base64 padding #12903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions core/src/test/java/io/grpc/internal/TransportFrameUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,15 @@ public void binaryHeaderWithoutSuffix() {
Metadata.Key.of("plainstring", UTF8_STRING_MARSHALLER);
}

@Test
public void binaryHeaderEncodedWithoutPadding() {
Metadata headers = new Metadata();
headers.put(BINARY_BYTES, new byte[] {1, 2, 3, 4, 5});
byte[][] http2Headers = TransportFrameUtil.toHttp2Headers(headers);
assertContains(
http2Headers, BINARY_BYTES.name().getBytes(US_ASCII), "AQIDBAU".getBytes(US_ASCII));
}

@Test
public void testToAndFromHttp2Headers() {
Metadata headers = new Metadata();
Expand Down Expand Up @@ -130,6 +139,24 @@ public void dupBinHeadersWithComma() {
values));
}

@Test
public void binaryHeaderDecodesPaddedBase64() {
byte[][] http2Headers = new byte[][] {
BINARY_BYTES.name().getBytes(US_ASCII), "AQIDBAU=".getBytes(US_ASCII)};
byte[][] rawSerialized = TransportFrameUtil.toRawSerializedHeaders(http2Headers);
Metadata recoveredHeaders = InternalMetadata.newMetadata(rawSerialized);
assertArrayEquals(new byte[] {1, 2, 3, 4, 5}, recoveredHeaders.get(BINARY_BYTES));
}

@Test
public void binaryHeaderDecodesUnpaddedBase64() {
byte[][] http2Headers = new byte[][] {
BINARY_BYTES.name().getBytes(US_ASCII), "AQIDBAU".getBytes(US_ASCII)};
byte[][] rawSerialized = TransportFrameUtil.toRawSerializedHeaders(http2Headers);
Metadata recoveredHeaders = InternalMetadata.newMetadata(rawSerialized);
assertArrayEquals(new byte[] {1, 2, 3, 4, 5}, recoveredHeaders.get(BINARY_BYTES));
}

private static void assertContains(byte[][] headers, byte[] key, byte[] value) {
String keyString = new String(key, US_ASCII);
for (int i = 0; i < headers.length; i += 2) {
Expand Down
Loading