refactor: remove duplicate DependencyAggregator from JavaMavenProvider#389
Merged
soul2zimate merged 1 commit intoguacsec:mainfrom Mar 31, 2026
Merged
Conversation
Contributor
Review Summary by QodoConsolidate DependencyAggregator into BaseJavaProvider base class
WalkthroughsDescription• Move DependencyAggregator class from JavaMavenProvider to BaseJavaProvider • Eliminate duplicate code by centralizing shared dependency aggregation logic • Remove unused imports (MalformedPackageURLException, TreeMap) from JavaMavenProvider • Add toPurlWithoutVersion() method to BaseJavaProvider for coordinate matching Diagramflowchart LR
A["JavaMavenProvider<br/>DependencyAggregator"] -- "move class" --> B["BaseJavaProvider<br/>DependencyAggregator"]
C["JavaMavenProvider<br/>unused imports"] -- "remove" --> D["cleaned imports"]
B -- "add method" --> E["toPurlWithoutVersion()"]
File Changes1. src/main/java/io/github/guacsec/trustifyda/providers/BaseJavaProvider.java
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
ruromero
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: remove duplicate DependencyAggregator from JavaMavenProvider