Skip to content

(Showcase) Fallback to playing project video from URL #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slashtechno wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(Showcase) Fallback to playing project video from URL #1342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions components/arcade/showcase/youtube-renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,28 @@ import LiteYouTubeEmbed from 'react-lite-youtube-embed';
import 'react-lite-youtube-embed/dist/LiteYouTubeEmbed.css'

const YoutubeRenderer = ({ youtubeLink }) => {
if (!youtubeLink) return null
const youtubeID = youtubeLink.split('v=')[1]
if (!youtubeID) return <p>Invalid YouTube link: "{youtubeLink}"</p>
if (!youtubeLink) return null;

const isYouTubeLink = youtubeLink.includes('youtube.com') || youtubeLink.includes('youtu.be');
if (isYouTubeLink) {
const youtubeID = youtubeLink.split('v=')[1];
Copy link
Member

@arnav-kr arnav-kr Aug 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

youtu.be links don't have v query param, thus no youtu.be links would render

if (!youtubeID) return <p>Invalid YouTube link: "{youtubeLink}"</p>;

return (
<LiteYouTubeEmbed
id={youtubeID}
adNetwork={false}
noCookie={true}
/>
);
}
return (
<LiteYouTubeEmbed
id={youtubeID}
adNetwork={false}
noCookie={true}
/>
)
}
<video controls>
<source src={youtubeLink} type="video/mp4" />
Your browser does not support the video tag.
</video>
);
};


export default YoutubeRenderer