Skip to content

Conversation

@santi-jose
Copy link
Member

@santi-jose santi-jose commented Nov 14, 2025

Fixes #8390

What changes did you make?

  • I replaced the instance of Github and github to GitHub within the GitHub property of toolkitresources.yml.

Why did you make the changes (we will use this info to test)?

  • To ensure we consistently display the name of the company GitHub correctly.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Connected Files:

_includes/current-guides.html: The current-guides.html file is included within the /toolkit page in the HFLA website. The toolkitresources.yml file is the data the current-guides.html file uses to populate the External Resources section of the /toolkit page. The changes made for this issue are reflected in the GitHub card within the External Resources section at the bottom of the /toolkit page.

.github/ISSUE_TEMPLATE/suggest-an-external-resource.md: The purpose of this markdown file is to serve as a template for suggesting a new external resource to add to the /toolkit page. Changes requested by this issue are not reflected in this markdown file.

Test Procedure:

  1. Create local feature branch and download the changes from GitHub
  2. Run the Docker container to run the HackForLA website locally and navigate to http://localhost:4000/toolkit/
  3. Open to the live HackForLA website toolkit page https://www.hackforla.org/toolkit/
  4. Scroll down to the External Resources section and observe the change between the GitHub cards text for GitHub between the feature branch and the live website.

Link to Test Procedure in Issue #8390 Comment

#8390 (comment)

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b santi-jose-replace-Github-and-github-with-GitHub-8390 gh-pages
git pull https://github.com/santi-jose/website.git replace-Github-and-github-with-GitHub-8390

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium status: Updated No blockers and update is ready for review P-Feature: Wins Page https://www.hackforla.org/wins/ size: 1pt Can be done in 4-6 hours labels Nov 14, 2025
@santi-jose santi-jose changed the title Changed 'Github' and 'github' to GitHub within /_data/internal/toolkitresources.yml Changed Github and github to GitHub within /_data/internal/toolkitresources.yml Nov 14, 2025
Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

You found all of the related files that I could find. You have good explanations for those files, as well as for the test procedure.

Good job.

@github-actions github-actions bot removed the status: Updated No blockers and update is ready for review label Nov 15, 2025
@myronchen-git
Copy link
Member

In regards to the suggest-an-external-resource.md issue template, I believe we should create a new issue to fix that as well, to remain consistent. The issue could be a good first issue. We will need to check this with someone who has been here longer.

@lc1715
Copy link
Member

lc1715 commented Nov 15, 2025

Review ETA: 11/14/25
Availability: 4-7pm Mon-Fri

Copy link
Member

@lc1715 lc1715 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue @santi-jose!

  • The PR was done with the correct branch and linked issue
  • You correctly replaced the instances of Github and github with GitHub in the toolkitresources.yml file
  • Your explanations for 'Connected Files' and 'Test Procedure' are clear and concise
  • The correct changes can be seen in the browser

@myronchen-git Good suggestion!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Nov 15, 2025
@daras-cu daras-cu merged commit f471463 into hackforla:gh-pages Nov 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours

Projects

Development

Successfully merging this pull request may close these issues.

Replace Github with GitHub in _data/internal/toolkitresources.yml

4 participants