-
-
Notifications
You must be signed in to change notification settings - Fork 843
Changed Github and github to GitHub within /_data/internal/toolkitresources.yml
#8421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed Github and github to GitHub within /_data/internal/toolkitresources.yml
#8421
Conversation
…s.yml file to 'GitHub'.
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
GitHub within /_data/internal/toolkitresources.ymlGithub and github to GitHub within /_data/internal/toolkitresources.yml
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good.
You found all of the related files that I could find. You have good explanations for those files, as well as for the test procedure.
Good job.
|
In regards to the |
|
Review ETA: 11/14/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this issue @santi-jose!
- The PR was done with the correct branch and linked issue
- You correctly replaced the instances of
GithubandgithubwithGitHubin thetoolkitresources.ymlfile - Your explanations for 'Connected Files' and 'Test Procedure' are clear and concise
- The correct changes can be seen in the browser
@myronchen-git Good suggestion!
Fixes #8390
What changes did you make?
GithubandgithubtoGitHubwithin theGitHubproperty oftoolkitresources.yml.Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Connected Files:
_includes/current-guides.html: The
current-guides.htmlfile is included within the/toolkitpage in the HFLA website. Thetoolkitresources.ymlfile is the data thecurrent-guides.htmlfile uses to populate the External Resources section of the/toolkitpage. The changes made for this issue are reflected in the GitHub card within the External Resources section at the bottom of the/toolkitpage..github/ISSUE_TEMPLATE/suggest-an-external-resource.md: The purpose of this markdown file is to serve as a template for suggesting a new external resource to add to the
/toolkitpage. Changes requested by this issue are not reflected in this markdown file.Test Procedure:
GitHubbetween the feature branch and the live website.Link to Test Procedure in Issue #8390 Comment
#8390 (comment)
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied