Skip to content

Added Farnaz to list of leadership #8318#8537

Open
jjam02 wants to merge 2 commits intohackforla:gh-pagesfrom
jjam02:Expunge-Assist-Add-Farnaz-S-8318
Open

Added Farnaz to list of leadership #8318#8537
jjam02 wants to merge 2 commits intohackforla:gh-pagesfrom
jjam02:Expunge-Assist-Add-Farnaz-S-8318

Conversation

@jjam02
Copy link
Member

@jjam02 jjam02 commented Feb 25, 2026

Fixes #8318

What changes did you make?

  • Added Farnaz S to show under current project team for expunge assist (expunge-assist.md)

Why did you make the changes (we will use this info to test)?

  • Farnaz S is a part of the Expunge Assist leadership and was missing from that section on the website

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied image
Visuals after changes are applied Screenshot 2026-02-26 at 6 06 19 PM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b jjam02-Expunge-Assist-Add-Farnaz-S-8318 gh-pages
git pull https://github.com/jjam02/website.git Expunge-Assist-Add-Farnaz-S-8318

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 25, 2026
@mocodesss mocodesss self-requested a review February 26, 2026 01:54
@mocodesss
Copy link
Member

mocodesss commented Feb 26, 2026

Review ETA: 7 PM 2/26/26
Availability: 6-11pm Mon - Thurs; Sun AMs

Copy link
Member

@mocodesss mocodesss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jjam02! The code itself looks good. Nice job! I'm not sure if the order is incorrect, though. I think Farnaz S is supposed to be added after Shraddha Saraf since they are also a Manager. I'll ask if that order matters before approving.

Image

@jjam02
Copy link
Member Author

jjam02 commented Feb 26, 2026

thank you for the review I notice the mistake now and have pushed a new commit with the order changed

@mocodesss
Copy link
Member

mocodesss commented Feb 26, 2026

Thanks for the update @jjam02! That order looks great!

Done correctly:

  • The merge from and to branches have been correctly set.
  • The issue has been correctly linked.
  • In the issue, you've correctly assigned yourself.
  • The CodeQL alerts have been correctly checked off.
  • In the issue, you've correctly set the project status.
  • Visuals before/after changes are applied.

Not, yet, correct:

  • In the issue, action items have correctly been checked off.

The only think that I think is missing is that you need this in the PR itself: (with the first box checked)


CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging


Here is an example: #8459

Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for completing this good first issue.


Done Correctly

  • The merge from and to branches have been correctly set.
  • The issue has been correctly linked.
  • The pull request title is named properly.
  • The what in the pull request description is adequately described.
  • Code changes have been correctly made.
  • In the originating issue, you've correctly assigned yourself.
  • In the originating issue, you've correctly set the project status.
  • In the originating issue, action items have correctly been checked off.
  • In the originating issue, you've given your availability and ETA.

Changes that need to be made

  • The CodeQL alerts should not be removed. I noticed that you created a new comment with it, but it needs to be in your first comment. Please edit your first comment to include the alerts.
  • The why description in your pull request would need to be the underlying reason of why the changes are needed. In this case, it would need to explain why Farnaz needs to be added to the Expunge Assist members list.
  • Your screenshot in the "after changes" section in your pull request needs to be updated to reflect the new position that Farnaz is in.

Optional recommendations

In your originating issue 8318, your availability should be a time and date range, so that others know the best time to contact you.


On a side note, in your originating issue 8318, you do not need to put before and after screenshots there. It is only needed in the pull request.

On another side note, once you have made changes in response to a reviewer's request, you need to re-request a review from that reviewer. You can do this by clicking on the circulating arrows next to the reviewer's name at the top right of this page.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Feb 26, 2026
Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for making the changes. Good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Status: PRs being reviewed

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Expunge Assist Add Farnaz S

3 participants