Added Farnaz to list of leadership #8318#8537
Added Farnaz to list of leadership #8318#8537jjam02 wants to merge 2 commits intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 7 PM 2/26/26 |
There was a problem hiding this comment.
Hi @jjam02! The code itself looks good. Nice job! I'm not sure if the order is incorrect, though. I think Farnaz S is supposed to be added after Shraddha Saraf since they are also a Manager. I'll ask if that order matters before approving.
|
thank you for the review I notice the mistake now and have pushed a new commit with the order changed |
|
Thanks for the update @jjam02! That order looks great! Done correctly:
Not, yet, correct:
The only think that I think is missing is that you need this in the PR itself: (with the first box checked) CodeQL AlertsAfter the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations. Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alertsIf CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts. In general, CodeQL alerts should be resolved prior to PR reviews and merging Here is an example: #8459 |
There was a problem hiding this comment.
Thank you for completing this good first issue.
Done Correctly
- The merge from and to branches have been correctly set.
- The issue has been correctly linked.
- The pull request title is named properly.
- The what in the pull request description is adequately described.
- Code changes have been correctly made.
- In the originating issue, you've correctly assigned yourself.
- In the originating issue, you've correctly set the project status.
- In the originating issue, action items have correctly been checked off.
- In the originating issue, you've given your availability and ETA.
Changes that need to be made
- The CodeQL alerts should not be removed. I noticed that you created a new comment with it, but it needs to be in your first comment. Please edit your first comment to include the alerts.
- The why description in your pull request would need to be the underlying reason of why the changes are needed. In this case, it would need to explain why Farnaz needs to be added to the Expunge Assist members list.
- Your screenshot in the "after changes" section in your pull request needs to be updated to reflect the new position that Farnaz is in.
Optional recommendations
In your originating issue 8318, your availability should be a time and date range, so that others know the best time to contact you.
On a side note, in your originating issue 8318, you do not need to put before and after screenshots there. It is only needed in the pull request.
On another side note, once you have made changes in response to a reviewer's request, you need to re-request a review from that reviewer. You can do this by clicking on the circulating arrows next to the reviewer's name at the top right of this page.
myronchen-git
left a comment
There was a problem hiding this comment.
Thank you very much for making the changes. Good work.

Fixes #8318
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied