Skip to content

Modified current-projects.js to remove OR logic from project filter#8538

Open
aadilahmed wants to merge 1 commit intohackforla:gh-pagesfrom
aadilahmed:update-project-filter-remove-or-logic-8353
Open

Modified current-projects.js to remove OR logic from project filter#8538
aadilahmed wants to merge 1 commit intohackforla:gh-pagesfrom
aadilahmed:update-project-filter-remove-or-logic-8353

Conversation

@aadilahmed
Copy link
Member

@aadilahmed aadilahmed commented Feb 25, 2026

Fixes #8353

What changes did you make?

  • Modified code on line 537 in updateProjectCardDisplayState method to ensure AND logic within same filter category
  • Added conditional to updateProjectCardDisplayState method to ensure AND logic between different filter categories

Why did you make the changes (we will use this info to test)?

  • To ensure that AND logic is applied to all filter categories selected on the project page
  • Make sure the filter is easier to use and navigate

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Screenshot 2026-02-25 at 03-18-02 Hack for LA
Visuals after changes are applied Screenshot 2026-02-25 at 03-18-09 Projects - Hack for LA

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b aadilahmed-update-project-filter-remove-or-logic-8353 gh-pages
git pull https://github.com/aadilahmed/website.git update-project-filter-remove-or-logic-8353

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Large status: To Update! No update has been provided P-Feature: Home page https://www.hackforla.org/ P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.5pt Can be done in 3 hours or less labels Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Large P-Feature: Home page https://www.hackforla.org/ P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less status: To Update! No update has been provided

Projects

Status: PR Needs review

Development

Successfully merging this pull request may close these issues.

Update Project Filters: Remove OR Logic Across and Within Filter Categories

1 participant