Skip to content

WIP: Add allow notification option to comment forms #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ruibaby wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: Add allow notification option to comment forms #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/comment-widget/src/base-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,14 @@ export class BaseForm extends LitElement {
</button> `
: ''
}

<div class="form-actions justify-end flex gap-2 flex-wrap items-center">

<div class="flex items-center gap-2">
<input id="allowNotification" name="allowNotification" type="checkbox" checked />
<label for="allowNotification" class="text-xs select-none text-text-3 hover:text-text-1 transition-all">${msg('Allow notification')}</label>
</div>

${
this.showCaptcha && this.captcha
? html`
Expand Down Expand Up @@ -292,6 +299,7 @@ export class BaseForm extends LitElement {
detail: {
...data,
content,
allowNotification: data.allowNotification === 'on',
},
});
this.dispatchEvent(event);
Expand Down
6 changes: 3 additions & 3 deletions packages/comment-widget/src/comment-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,13 @@ export class CommentForm extends LitElement {

const data = e.detail;

const { displayName, email, website, content } = data || {};
const { displayName, email, website, content, allowNotification } =
data || {};

const commentRequest: CommentRequest = {
raw: content,
content: content,
// TODO: support user input
allowNotification: true,
allowNotification: allowNotification,
subjectRef: {
group: this.group,
kind: this.kind,
Expand Down
6 changes: 3 additions & 3 deletions packages/comment-widget/src/reply-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,13 @@ export class ReplyForm extends LitElement {

const data = e.detail;

const { displayName, email, website, content } = data || {};
const { displayName, email, website, content, allowNotification } =
data || {};

const replyRequest: ReplyRequest = {
raw: content,
content: content,
// TODO: support user input
allowNotification: true,
allowNotification: allowNotification,
};

if (this.quoteReply) {
Expand Down