Fix registerLanguage() issue in the code examples#1484
Merged
Conversation
budnix
approved these changes
Jan 15, 2025
Performance comparison of head (43713d9) vs base (cdb234e) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1484 +/- ##
========================================
Coverage 97.22% 97.22%
========================================
Files 169 169
Lines 14523 14523
Branches 3080 3080
========================================
Hits 14120 14120
Misses 403 403 |
sequba
added a commit
that referenced
this pull request
Jan 15, 2025
… (#1487) * Fix registerLanguage() issue in the code examples (#1484) Make code examples check for registered languages before registering new ones * Fix mortgage calculator demo error `Cannot load native addon because loading addons is disabled` (#1486) Migrate mortgage-calculator demo in readme from Codestandbox to Stackblitz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Code examples now check for registered languages before registering new ones.
How did you test your changes?
local docs build
Types of changes
Related issues:
Language already registerederror in the i18n demo when switching between docs pages #1481Checklist: