Skip to content

Add Rotation Manager stubs for OSS#26360

Closed
vinay-gopalan wants to merge 2 commits intoVAULT-21042/core-managed-rotate-pocfrom
VAULT-24465/code-migration
Closed

Add Rotation Manager stubs for OSS#26360
vinay-gopalan wants to merge 2 commits intoVAULT-21042/core-managed-rotate-pocfrom
VAULT-24465/code-migration

Conversation

@vinay-gopalan
Copy link
Copy Markdown
Contributor

Removes rotation manager logic from Vault CE and adds OSS stubs.

@vinay-gopalan vinay-gopalan requested a review from a team as a code owner April 10, 2024 22:21
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 10, 2024
@github-actions
Copy link
Copy Markdown

Build Results:
Build failed for these jobs: test:failure. Please refer to this workflow to learn more: https://github.com/hashicorp/vault/actions/runs/8638599950

@github-actions
Copy link
Copy Markdown

CI Results:
Failures:

Test Type Package Test Logs
builtin/credential/ldap TestBackend_basic view test results
builtin/credential/ldap TestBackend_basic_authbind view test results
builtin/credential/ldap TestBackend_basic_authbind_metadata_name view test results
builtin/credential/ldap TestBackend_basic_authbind_userfilter view test results
builtin/credential/ldap TestBackend_basic_discover view test results
builtin/credential/ldap TestBackend_basic_group_noPolicies view test results
builtin/credential/ldap TestBackend_basic_noPolicies view test results
builtin/credential/ldap TestBackend_basic_nogroupdn view test results
builtin/credential/ldap TestBackend_configDefaultsAfterUpdate view test results
builtin/credential/ldap TestLdapAuthBackend_CaseSensitivity view test results

and 39 other tests

Copy link
Copy Markdown
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants