Skip to content

VAULT-34830 actions(plugin-update): update plugins from enterprise#31474

Merged
ryancragun merged 2 commits intomainfrom
ryan/VAULT-34830-plugins
Aug 15, 2025
Merged

VAULT-34830 actions(plugin-update): update plugins from enterprise#31474
ryancragun merged 2 commits intomainfrom
ryan/VAULT-34830-plugins

Conversation

@ryancragun
Copy link
Copy Markdown
Collaborator

@ryancragun ryancragun commented Aug 11, 2025

Description

Support updating both CE and Enterprise plugins when the plugin update workflow targets vault-enterprise instead of CE.

This needs to be merged in conjunction with https://github.com/hashicorp/vault-plugin-release/pull/62 right before we do the merge workflow cutover.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@ryancragun ryancragun requested a review from a team as a code owner August 11, 2025 18:26
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 11, 2025
@github-actions
Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

Comment thread .github/workflows/plugin-update.yml Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am understanding correctly, this will only work if we always include the +ent version metadata in the plugin version. We don't currently do that for plugins that have always been Enterpise-only. For example https://github.com/hashicorp/vault-plugin-secrets-kmip/tags. However, if this is the approach you would recommend, then we can probably start doing that?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. I think I'll just pass in whether or not it's an enterprise plugin from the caller which can be derived from the plugins.yaml?

Signed-off-by: Ryan Cragun <me@ryan.ec>
@ryancragun ryancragun force-pushed the ryan/VAULT-34830-plugins branch from cef5873 to bdf84c4 Compare August 12, 2025 17:05
@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
vault-ui Ready Preview Comment Aug 12, 2025 5:15pm

Copy link
Copy Markdown
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryancragun ryancragun merged commit b5b4a95 into main Aug 15, 2025
75 checks passed
@ryancragun ryancragun deleted the ryan/VAULT-34830-plugins branch August 15, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants