VAULT-34830 actions(plugin-update): update plugins from enterprise#31474
Merged
ryancragun merged 2 commits intomainfrom Aug 15, 2025
Merged
VAULT-34830 actions(plugin-update): update plugins from enterprise#31474ryancragun merged 2 commits intomainfrom
ryancragun merged 2 commits intomainfrom
Conversation
|
CI Results: |
|
Build Results: |
fairclothjm
reviewed
Aug 11, 2025
Contributor
There was a problem hiding this comment.
If I am understanding correctly, this will only work if we always include the +ent version metadata in the plugin version. We don't currently do that for plugins that have always been Enterpise-only. For example https://github.com/hashicorp/vault-plugin-secrets-kmip/tags. However, if this is the approach you would recommend, then we can probably start doing that?
Collaborator
Author
There was a problem hiding this comment.
No worries. I think I'll just pass in whether or not it's an enterprise plugin from the caller which can be derived from the plugins.yaml?
Signed-off-by: Ryan Cragun <me@ryan.ec>
Signed-off-by: Ryan Cragun <me@ryan.ec>
cef5873 to
bdf84c4
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anwittin
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support updating both CE and Enterprise plugins when the plugin update workflow targets
vault-enterpriseinstead of CE.This needs to be merged in conjunction with https://github.com/hashicorp/vault-plugin-release/pull/62 right before we do the merge workflow cutover.
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.