Skip to content

UI: Fix download service#31504

Closed
hellobontempo wants to merge 1 commit intomainfrom
fix-download-service
Closed

UI: Fix download service#31504
hellobontempo wants to merge 1 commit intomainfrom
fix-download-service

Conversation

@hellobontempo
Copy link
Copy Markdown
Contributor

Description

Not sure when - but at some point the "Export activity" button stopped working. I'm not really sure what caused it, but removing the appendage of DOM objects resolved the issue. The binary is working fine, so it could also just be an issue on :4200.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@hellobontempo hellobontempo added this to the 1.21.0-rc1 milestone Aug 15, 2025
@hellobontempo hellobontempo requested a review from a team as a code owner August 15, 2025 16:20
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 15, 2025
const data = new File([content], formattedFilename, { type: mimetype });
downloadElement.download = formattedFilename;
downloadElement.href = URL.createObjectURL(data);
document.body.appendChild(downloadElement);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed and once deleted, the download succeeded.

Strange enough, the download would also work if the method was called twice. Adding a fake download call would yield a successful download (with the actual contents arg, not the faked data)....super strange

  exportChartData = task({ drop: true }, async (filename) => {
  // call download with test data
  this.download.download('test', 'hello world', 'txt');
    try {
      const contents = await this.getExportData();
      this.download.download(filename, contents, this.exportFormat);
      this.showExportModal = false;
    } catch (e) {
      this.downloadError = e.message;
    }
  });

@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@github-actions
Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@hc-github-team-secure-vault-core
Copy link
Copy Markdown
Collaborator

Copy workflow completed!

From To Error
hashicorp/vault#2749146823 hashicorp/vault-enterprise#2749540917

@hellobontempo
Copy link
Copy Markdown
Contributor Author

Closing to merge this directly into enterprise

@hellobontempo hellobontempo deleted the fix-download-service branch September 18, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants