Feat: enable agent to use mTLS communication #49
Open
yungcero wants to merge 5 commits intohashtopolis:masterfrom
Open
Feat: enable agent to use mTLS communication #49yungcero wants to merge 5 commits intohashtopolis:masterfrom
yungcero wants to merge 5 commits intohashtopolis:masterfrom
Conversation
Author
|
@s3inlc thoughts on this feature? |
Contributor
|
This is already the --cert flag for specifying a client cert |
Author
|
Yes, but unless the client key is bundled in with the cert file, it won't work since the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a feature to the hashtopolis agent-python that allows the option for the agent to use mTLS verification in its session with the hashtopolis server. This is helpful if the hashtopolis server is configured to use mTLS for additional security.
By default it will be disabled unless someone has the need/use case to enable mTLS comms. The changes take advantage of the use of the requests.session class that is being used to handle client/server communication.
Also whitespace is stripped and single ticks '' have been changed to quotations "" due to my editor.