Open
Conversation
L0neGamer
force-pushed
the
more-ci-versions
branch
3 times, most recently
from
dff50e9 to
ca8d4a2
Compare
L0neGamer
force-pushed
the
more-ci-versions
branch
2 times, most recently
from
b830253 to
6e526f6
Compare
Collaborator
Author
|
As per https://discourse.haskell.org/t/state-of-haskell-2025-results/13755, only ~4% of haskellers aren't on GHC 8.10 or after. |
Collaborator
|
This is fantastic. Can I suggest that you replace |
sjshuck
approved these changes
Apr 4, 2026
if a non-ghc compiler adds generics we can change this back
L0neGamer
force-pushed
the
more-ci-versions
branch
from
4f82ef6 to
6b88bdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I add a tested-with clause that matches our ci-tested compilers.
I classify all generics implementation details with the GENERICS CPP flag to gate it away from mhs.
I drop support for ghc versions prior to GHC 8.10, and then I cleanup much of the CPP associated with the related version gating.
I also adjust Data.Functor.Constant's deprecation warning to explicitly state that it will be removed in transformers version 0.7.
The remaining
__GLASGOW_HASKELL__checks are for Data instances in a deprecated module, and allMIN_VERSION_basechecks are for changes in the GHC 9.* additions.This sets our minimum compatibility version to 8.10.7, which is higher than discussed in #104.