Export GFromRow and GToRow for use as constraints#84
Open
carymrobbins wants to merge 1 commit intohaskellari:masterfrom
Open
Export GFromRow and GToRow for use as constraints#84carymrobbins wants to merge 1 commit intohaskellari:masterfrom
carymrobbins wants to merge 1 commit intohaskellari:masterfrom
Conversation
Contributor
Author
|
Looks like the checks failed only on AppVeyor, which looks to be a linker error. @phadej - Are you the one to approve/merge this? Would be good to know if this change would be accepted or if there is some alternative you'd like instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for generalizing over things which can have their
FromRowandToRowinstances derived. Specifically, this would enable libraries like generic-override to be able to interop withpostgresql-simple's generic machinery.Without this change, given the following code -
We'll get the following compiler error -
This can be easily fixed by adding the
GToRowconstraint -However, this can't be done unless the constraint itself is exported.