Conversation
Ko builds the binary locally and utilizes the local go build cache. This makes the deployment with skaffold faster locally and in our e2e tests. This makes the dev setup more different than the production setup (still using Dockerfile). But they were already a bit different anyway. In the mid-term I want to use `ko` for the production images too.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
==========================================
+ Coverage 72.16% 72.26% +0.09%
==========================================
Files 31 32 +1
Lines 2497 2668 +171
==========================================
+ Hits 1802 1928 +126
- Misses 523 552 +29
- Partials 172 188 +16 ☔ View full report in Codecov by Sentry. |
Member
Author
|
In e2e tests this reduced the time of the |
Contributor
|
This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs. |
Contributor
|
This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ko builds the binary locally and utilizes the local go build cache.
This makes the deployment with skaffold faster locally and in our e2e tests.
This makes the dev setup more different than the production setup (still using Dockerfile). But they were already a bit different anyway. In the mid-term I want to use
kofor the production images too.