feat(core): expose hf-ids as subpath export for @hyperframes/sdk#1323
Open
vanceingalls wants to merge 1 commit into
Open
feat(core): expose hf-ids as subpath export for @hyperframes/sdk#1323vanceingalls wants to merge 1 commit into
vanceingalls wants to merge 1 commit into
Conversation
Collaborator
Author
0a1617e to
0c5614f
Compare
miguel-heygen
approved these changes
Jun 10, 2026
miguel-heygen
left a comment
Collaborator
There was a problem hiding this comment.
Clean, minimal change. The subpath export is correctly placed in both the dev (src/) and dist (publishConfig.exports) conditions, consistent with the pattern used by ./gsap-parser and ./runtime/mediaVolumeEnvelope. No issues.
james-russo-rames-d-jusso
left a comment
There was a problem hiding this comment.
Quick approve from my side. Two new entries in packages/core/package.json exports (one src-mode for dev workspace consumers, one publish-mode for the dist build) pointing @hyperframes/core/hf-ids at the existing parsers/hfIds.ts module.
Verified:
packages/core/src/parsers/hfIds.tsexists at this SHA and exposes the expected surface (mintHfId,ensureHfIds).- Both exports symmetrically defined under
exports.andpublishConfig.exports.— no risk of dev-mode + publish-mode drift. - Alphabetic ordering within the exports map is preserved (sits between
mediaVolumeEnvelopeandgsap-parser). - The subpath name
hf-ids(hyphen) follows the existing convention for kebab-case subpaths (gsap-parser,dom-edit, etc.). Internal file ishfIds.ts(camelCase) — fine, file naming and subpath naming are independent contracts.
The SDK consumer in #1324 (packages/sdk/src/document.ts:12) actually uses this import — confirmed it resolves correctly through the workspace.
Trivial enabler. LGTM.
— Review by Rames D Jusso
0c5614f to
865aa69
Compare
This was referenced Jun 11, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Exposes
hf-idsas a dedicated subpath export from@hyperframes/coreso@hyperframes/sdkcan import ID-stamping logic without pulling in the full core bundle."exports"entry for./hf-idsinpackages/core/package.jsonWhy
@hyperframes/sdkneedsparseMutable/stampHfIdsfrom core. A subpath export isolates that boundary and keeps the SDK bundle lean.Test plan
bun run build— both packages build without errorsbun test packages/sdk— import resolves correctly🤖 Generated with Claude Code