Skip to content

test(core): cover video timing StaticGuard regression #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
phucsd1 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Draft

test(core): cover video timing StaticGuard regression #2747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/core/src/compiler/htmlBundler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1363,21 +1363,24 @@ describe("bundleToSingleHtml", () => {
<div data-composition-id="root" data-width="1920" data-height="1080" data-start="0" data-duration="18">
<audio id="bgm" src="bgm.mp3" data-start="0" data-duration="18"></audio>
<audio id="narration" src="narr.mp3" data-start="5" data-duration="10"></audio>
<video id="demo" src="demo.mp4" muted playsinline data-start="6" data-duration="8"></video>
</div>
<script>window.__timelines = window.__timelines || {}; window.__timelines.root = { duration: () => 18, seek() {}, pause() {} };</script>
</body></html>`,
"bgm.mp3": "",
"narr.mp3": "",
"demo.mp4": "",
});

const warnSpy = vi.spyOn(console, "warn").mockImplementation(() => {});
try {
const bundled = await bundleToSingleHtml(dir);
// Sanity: the compiler MUST have emitted data-end for both audio elements,
// Sanity: the compiler MUST have emitted data-end for every media element,
// so the linter is actually seeing the compiled shape (not the raw source).
expect(bundled).toContain('id="bgm"');
expect(bundled).toMatch(/id="bgm"[^>]*data-end="18"|data-end="18"[^>]*id="bgm"/);
expect(bundled).toMatch(/id="narration"[^>]*data-end="15"|data-end="15"[^>]*id="narration"/);
expect(bundled).toMatch(/id="demo"[^>]*data-end="14"|data-end="14"[^>]*id="demo"/);

const staticGuardWarnings = warnSpy.mock.calls
.map((call) => String(call[0] ?? ""))
Expand Down