Fix parameter anonymization #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch we removed both `name` and `declname`. Turns out that the only node using `name` for a "label" (for lack of a better word) was `Decl`. The rest of the nodes encoded actual useful typenames. This meant that, if the variable name and its type were the same (common thing with `struct`s), we would erase _both_ of them, which leads to broken signatures. The fix is simple: do not touch `name`. The codegen seems more than happy to generate anonymized parameters like this, as tested on libdecor (which led me to this), libwayland-client-core, xlib, and pulseaudio (which didn't build on Godot though due to a missing type? seems unrelated)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch we removed both
nameanddeclname.Turns out that the only node using
namefor a "label" (for lack of a better word) wasDecl. The rest of the nodes encoded actual useful typenames.This meant that, if the variable name and its type were the same (common thing with
structs), we would erase both of them, which leads to broken signatures.The fix is simple: do not touch
name. The codegen seems more than happy to generate anonymized parameters like this, as tested on libdecor (which led me to this), libwayland-client-core, xlib, and pulseaudio (which didn't build on Godot though due to a missing type? seems unrelated)