Remove unused mapped_rgns field from memory manager#1510
Open
ludfjig wants to merge 1 commit into
Open
Conversation
ludfjig
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
simongdavies,
squillace and
syntactically
as code owners
ludfjig
added
the
kind/enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused mapped_rgns counter from SandboxMemoryManager, along with the last remaining increments at mapping sites. This simplifies the host memory manager state now that snapshot restore logic tracks mappings via region set-differences (as introduced in #742), and no readers remain.
Changes:
- Removed the
mapped_rgns: u64field fromSandboxMemoryManagerand its initialisation/copying paths. - Deleted
mapped_rgnsincrement sites during sandbox evolve and mapping operations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/hyperlight_host/src/sandbox/uninitialized_evolve.rs | Removes obsolete mapped_rgns increment during apply-pending file mappings. |
| src/hyperlight_host/src/sandbox/initialized_multi_use.rs | Removes obsolete mapped_rgns increments when mapping regions / file mappings. |
| src/hyperlight_host/src/mem/mgr.rs | Removes mapped_rgns from SandboxMemoryManager struct and constructors/build paths. |
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
cleanup-mapped-rgns
branch
from
37fa994 to
2ba3e1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused mapped_rgns counter from SandboxMemoryManager. #742 replaced the old count-diff restore with Vec set-difference and deleted every reader.