Provide a WholeProjectDecompiler constructor with no default parameter values - #3903
Open
ds5678 wants to merge 2 commits into
Open
Provide a WholeProjectDecompiler constructor with no default parameter values#3903ds5678 wants to merge 2 commits into
ds5678 wants to merge 2 commits into
Conversation
1 task
ds5678
force-pushed
the
iassemblyreferenceclassifier
branch
from
July 30, 2026 06:17
b46abed to
e3f45c8
Compare
siegfriedpammer
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I'm trying to trim types from my application, and I'm having issues with the NativeAOT compiler not realizing that my parameters are never null.
ILSpy/ICSharpCode.Decompiler/CSharp/ProjectDecompiler/WholeProjectDecompiler.cs
Line 130 in 9898add
ILSpy/ICSharpCode.Decompiler/CSharp/ProjectDecompiler/WholeProjectDecompiler.cs
Line 132 in 9898add
Solution
IAssemblyReferenceClassifierand replaced most uses ofAssemblyReferenceClassifierwith it.WholeProjectDecompilerconstructor to the second most one.ArgumentNullExceptionchecks to the most specificWholeProjectDecompilerconstructor.