Skip to content

Rebase Vite/Vitest tooling onto our stack (keep MAX_BUFFER_SIZE fix)#89

Open
OBrezhniev wants to merge 3 commits into
feature/sharedArrayBuffersfrom
feature/esm-tooling
Open

Rebase Vite/Vitest tooling onto our stack (keep MAX_BUFFER_SIZE fix)#89
OBrezhniev wants to merge 3 commits into
feature/sharedArrayBuffersfrom
feature/esm-tooling

Conversation

@OBrezhniev

Copy link
Copy Markdown
Member

Rebase tooling migration onto our stack (Vite + Vitest)

Applies feat/esm-migration tooling on top of our feature/sharedArrayBuffers
work. Target: feat/esm-migration.

  • Rollup → Vite (node build/main.cjs + browser ESM), Mocha → Vitest with
    node + browser (Playwright) projects, flat eslint.config.js, CI.
  • Keeps our src/binfileutils.js: the MAX_BUFFER_SIZE = 1 GiB constant.
    feat/esm-migration reintroduced the Buffer.constants.MAX_LENGTH probe,
    which is always undefined (those constants live on the buffer module, not
    the Buffer class) — the bug we fixed. Please take this version.
  • Keeps our git+https pins (fastfile/ffjavascript) + audit overrides.

Validation: lint clean, node + browser round-trip tests pass.

Rollup -> Vite (node build/main.cjs + new browser ESM build), Mocha -> Vitest
with node + browser (Playwright) projects, flat eslint.config.js, CI workflow.
Adds the first real test coverage (node + browser round-trip). Keeps OUR
src/binfileutils.js (the MAX_BUFFER_SIZE 1 GiB constant — their branch
reintroduces the buggy Buffer.constants probe we fixed) and our git+https
pins. node + browser tests pass; CJS require + browser ESM verified.
@OBrezhniev

Copy link
Copy Markdown
Member Author

ESM-rebase set — the tooling migration re-applied on top of our optimization stack (rather than replaying the branches), so the MSM/CIOS/memory work is preserved. Review together:

Deviations from feat/esm-migration are called out in each PR body (e.g. binfileutils MAX_BUFFER_SIZE, snarkjs IIFE/bfj, mnt6753 excluded, smart_contracts test deferred). All branches keep git+https commit-ref pins; re-pin if a branch moves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant