Implement View Helper pattern#3278
Merged
iluwatar merged 13 commits intoiluwatar:masterfrom Feb 8, 2026
Merged
Conversation
# Conflicts: # pom.xml
PR SummaryImplemented the View Helper design pattern by adding a new view-helper module. Introduced Product, ProductViewModel, and ProductViewHelper to format data; included ProductController to coordinate between data, helper, and view; ConsoleProductView renders the formatted data. Updated Maven to expose the new module. Added unit tests AppTest and ProductViewHelperTest and included diagrams and README. Fixes #1263. Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (11)
- 3e1263e: Merge remote-tracking branch 'upstream/master' into 1263-view-helper
Conflicts:
pom.xml
- 9904085: #1263 - creating README and diagrams
- 3dbc8ef: #1263 - keeping module in alphabetical order
- faa7d0a: #1263 - adding license header
- 1e839fa: #1263 - creating main App and its test
- bf56994: #1263 - creating ProductController
- 442e1f8: #1263 - creating Console View for Product
- 69f020b: #1263 - creating ProductViewHelper and its test
- b365be5: #1263 - creating interfaces for View and ViewHelper
- a225935: #1263 - creating Product and ProductViewModel
- a404596: #1263 - creating new module for view-helper
Files Processed (17)
- pom.xml (2 hunks)
- view-helper/README.md (1 hunk)
- view-helper/etc/view-helper-sequence-diagram.png (0 hunks)
- view-helper/etc/view-helper-sequence-diagram.puml (1 hunk)
- view-helper/etc/view-helper.png (0 hunks)
- view-helper/etc/view-helper.puml (1 hunk)
- view-helper/pom.xml (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/App.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ConsoleProductView.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/Product.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ProductController.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ProductViewHelper.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ProductViewModel.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/View.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ViewHelper.java (1 hunk)
- view-helper/src/test/java/com/iluwatar/viewhelper/AppTest.java (1 hunk)
- view-helper/src/test/java/com/iluwatar/viewhelper/ProductViewHelperTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Files Processed (16)
- pom.xml (2 hunks)
- view-helper/README.md (1 hunk)
- view-helper/etc/view-helper-sequence-diagram.png (0 hunks)
- view-helper/etc/view-helper-sequence-diagram.puml (1 hunk)
- view-helper/etc/view-helper.png (0 hunks)
- view-helper/etc/view-helper.puml (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/App.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ConsoleProductView.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/Product.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ProductController.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ProductViewHelper.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ProductViewModel.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/View.java (1 hunk)
- view-helper/src/main/java/com/iluwatar/viewhelper/ViewHelper.java (1 hunk)
- view-helper/src/test/java/com/iluwatar/viewhelper/AppTest.java (1 hunk)
- view-helper/src/test/java/com/iluwatar/viewhelper/ProductViewHelperTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
|
|
This PR is stale because it has been open 60 days with no activity. |
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 26731ae: Merge branch 'master' into 1263-view-helper
Files Processed (1)
- pom.xml (2 hunks)
Actionable Comments (0)
Skipped Comments (1)
-
pom.xml [246-246]
enhancement: "Introduce new module view-helper; ensure module is self-contained."
|
Owner
|
@all-contributors please add @e5LA for code |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements the View Helper design pattern to improve the separation of concerns within the application. It introduces a View Helper class responsible for handling data formatting and processing tasks. The Controller is updated to delegate relevant responsibilities to the View Helper, and the View is refactored to consume the prepared data, resulting in cleaner, more maintainable code.
Fixes #1263