Skip to content

[v12] feat(ui-checkbox): Checkbox rework new v12#2428

Open
git-nandor wants to merge 1 commit intov12from
INSTUI-4788_checkbox_rework_new_v12
Open

[v12] feat(ui-checkbox): Checkbox rework new v12#2428
git-nandor wants to merge 1 commit intov12from
INSTUI-4788_checkbox_rework_new_v12

Conversation

@git-nandor
Copy link
Contributor

INSTUI-4788

Summary

Migrated Checkbox component from the old theming system.

Test plan

On the documentation page, verify that everything displays and works correctly.

Figma:

Co-Authored-By: 🤖 Claude

@git-nandor git-nandor self-assigned this Mar 5, 2026
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2428/

Built to branch gh-pages at 2026-03-11 14:26 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@git-nandor git-nandor marked this pull request as ready for review March 5, 2026 12:24
@git-nandor git-nandor force-pushed the INSTUI-4788_checkbox_rework_new_v12 branch from 8df2436 to 53f985c Compare March 9, 2026 08:48
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! as I see it conforms the design and all tokens are used

"require": "./lib/exports/a.js",
"default": "./es/exports/a.js"
"types": "./types/exports/b.d.ts",
"import": "./es/exports/b.js",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temporary version bump for design review

Copy link
Collaborator

@adamlobler adamlobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed earlier that the pointer cursor should also appear on hover over the label text. Could you fix it?

@git-nandor git-nandor requested a review from adamlobler March 11, 2026 13:47
@git-nandor git-nandor force-pushed the INSTUI-4788_checkbox_rework_new_v12 branch from 63184d6 to 177756d Compare March 11, 2026 13:50
@git-nandor git-nandor force-pushed the INSTUI-4788_checkbox_rework_new_v12 branch from 177756d to a35382b Compare March 11, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants