Skip to content

[v12] feat(ui-modal): Modal rework new v12#2430

Open
git-nandor wants to merge 1 commit intov12from
INSTUI-4797_modal_rework_new_v12
Open

[v12] feat(ui-modal): Modal rework new v12#2430
git-nandor wants to merge 1 commit intov12from
INSTUI-4797_modal_rework_new_v12

Conversation

@git-nandor
Copy link
Contributor

INSTUI-4797

Summary

Migrated Modal component from the old theming system.
Add fixes for previous PR

Test plan

On the documentation page, verify that everything displays and works correctly.

@git-nandor git-nandor self-assigned this Mar 5, 2026
@git-nandor git-nandor changed the base branch from master to v12 March 5, 2026 14:16
@git-nandor git-nandor marked this pull request as ready for review March 5, 2026 14:16
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2430/

Built to branch gh-pages at 2026-03-11 14:49 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@git-nandor git-nandor force-pushed the INSTUI-4797_modal_rework_new_v12 branch 2 times, most recently from 8218a93 to e364f06 Compare March 9, 2026 08:47
@git-nandor git-nandor requested review from HerrTopi and removed request for joyenjoyer March 9, 2026 10:45
"import": "./es/exports/a.js",
"require": "./lib/exports/a.js",
"default": "./es/exports/a.js"
"types": "./types/exports/b.d.ts",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temp version bump for design review

@git-nandor git-nandor force-pushed the INSTUI-4797_modal_rework_new_v12 branch from c30f401 to 40c17f9 Compare March 9, 2026 15:29
Copy link
Collaborator

@adamlobler adamlobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, nice work 🙌

@git-nandor git-nandor force-pushed the INSTUI-4797_modal_rework_new_v12 branch from 40c17f9 to 213c3c1 Compare March 11, 2026 14:40
@git-nandor git-nandor force-pushed the INSTUI-4797_modal_rework_new_v12 branch from 213c3c1 to d5094c4 Compare March 11, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants