Skip to content

[v12] feat(ui-pagination): Pagination rework new v12#2432

Open
git-nandor wants to merge 3 commits intov12from
INSTUI-4799_pagination_rework_new_v12
Open

[v12] feat(ui-pagination): Pagination rework new v12#2432
git-nandor wants to merge 3 commits intov12from
INSTUI-4799_pagination_rework_new_v12

Conversation

@git-nandor
Copy link
Contributor

INSTUI-4799

Summary

Migrated Pagination component from the old theming system.

Test plan

On the documentation page, verify that everything displays and works correctly.

Co-Authored-By: 🤖 Claude

@git-nandor git-nandor self-assigned this Mar 5, 2026
@git-nandor git-nandor marked this pull request as ready for review March 5, 2026 15:27
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2432/

Built to branch gh-pages at 2026-03-09 16:43 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@git-nandor git-nandor force-pushed the INSTUI-4799_pagination_rework_new_v12 branch from 6952f5a to 3131b71 Compare March 9, 2026 08:35
Copy link
Contributor

@joyenjoyer joyenjoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no space after the text input in one of the examples. On master, there is a space.

Image

Thanks, that’s the value of the inputSpacing token. I’ll discuss it with Ádám.

@git-nandor git-nandor force-pushed the INSTUI-4799_pagination_rework_new_v12 branch 2 times, most recently from e0b2a88 to a5be44b Compare March 9, 2026 16:10
@git-nandor git-nandor force-pushed the INSTUI-4799_pagination_rework_new_v12 branch from a5be44b to 1a1dca1 Compare March 9, 2026 16:11
@git-nandor git-nandor force-pushed the INSTUI-4799_pagination_rework_new_v12 branch from 2a94341 to 548ee30 Compare March 9, 2026 16:19
@adamlobler
Copy link
Collaborator

There is no space after the text input in one of the examples. On master, there is a space.

Image Thanks, that’s the value of the inputSpacing token. I’ll discuss it with Ádám.

This value was 0.25rem so it was wrong, I updated it so now its 0.5rem but based on the screenshot it looks like it doesn't get the value at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants