Skip to content

feat(ui-navigation): rework AppNav#2437

Open
ToMESSKa wants to merge 1 commit intov12from
INSTUI-4783-app-nav-rework2
Open

feat(ui-navigation): rework AppNav#2437
ToMESSKa wants to merge 1 commit intov12from
INSTUI-4783-app-nav-rework2

Conversation

@ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Mar 10, 2026

INSTUI-4783

ISSUE:

  • AppNav needs to be migrated to the new theming system

TEST PLAN:

  • check if the component works the same as before in v1
  • check if the components and the examples work in v2 (especially the dark theme)
  • check if all necessary the imports are renamed to v11_6 in v1
  • check if all necessary the imports are renamed to latest in v2
  • check if the test files are removed from the v1
  • check if the right imports are used in packages/ui-navigation/src/exports/b.ts and packages/ui-navigation/src/exports/a.ts
  • check if the packages/ui-navigation/package.json uses the correct versioning
  • check if the renamed or removed tokes are documented in the upgrade guide
  • check if the index.ts files use withStyle instead of withStyleLegacy

Comment on lines +75 to +78
"types": "./types/exports/b.d.ts",
"import": "./es/exports/b.js",
"require": "./lib/exports/b.js",
"default": "./es/exports/b.js"
Copy link
Contributor Author

@ToMESSKa ToMESSKa Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary fix to see the v2 in the PR preview

@github-actions
Copy link

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2437/

Built to branch gh-pages at 2026-03-10 10:46 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Comment on lines +572 to +575
// const showRebrandThemes =
// this.state.showMinorVersionSelector &&
// this.state.selectedMinorVersion !== 'v11_6'
const showRebrandThemes = true // TODO temp workaround
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary fix to see the the v2 in the PR preview

@ToMESSKa ToMESSKa requested review from balzss, hajnaldo and matyasf March 10, 2026 11:00
@ToMESSKa ToMESSKa changed the title feat(ui-navigation): rework AppNav [v12] feat(ui-navigation): rework AppNav Mar 10, 2026
@ToMESSKa ToMESSKa self-assigned this Mar 10, 2026
@ToMESSKa ToMESSKa changed the title [v12] feat(ui-navigation): rework AppNav feat(ui-navigation): rework AppNav Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant