Skip to content

feat(ui-toggle-details): fix issues with rework ToggleDetails and ToggleGroup after the multi version merge#2438

Merged
balzss merged 1 commit intov12from
INSTUI-4815-toggle-details-rework2
Mar 13, 2026
Merged

feat(ui-toggle-details): fix issues with rework ToggleDetails and ToggleGroup after the multi version merge#2438
balzss merged 1 commit intov12from
INSTUI-4815-toggle-details-rework2

Conversation

@ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Mar 10, 2026

INSTUI-4815

ISSUES:

  • ToggleDetails contained some incorrect imports, see the original PR here
  • v12 was missing ToggleGroup v2 despite it has already been reworked, see the original PR here

TEST PLAN:

  • check if the component works the same as before in v1 (for now, you can do this only locally)
  • check if the components and the examples work in v2 (especially the dark theme) (for now, you can do this only locally)
  • check if all necessary the imports are renamed to v11_6 in v1
  • check if all necessary the imports are renamed to latest in v2
  • check if the test files are removed from the v1
  • check if the right imports are used in packages/ui-toggle-details/src/exports/b.ts and packages/ui-toggle-details/src/exports/a.ts
  • check if the packages/ui-toggle-details/package.json uses the correct versioning
  • check if the renamed or removed tokes are documented in the upgrade guide
  • check if the index.ts files use withStyle instead of withStyleLegacy

@github-actions
Copy link

github-actions bot commented Mar 10, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-03-13 09:41 UTC

@ToMESSKa ToMESSKa requested review from HerrTopi and matyasf March 10, 2026 13:20
@ToMESSKa ToMESSKa self-assigned this Mar 10, 2026
@ToMESSKa ToMESSKa force-pushed the INSTUI-4815-toggle-details-rework2 branch from 52cee37 to d8fad3c Compare March 11, 2026 15:20
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@balzss balzss merged commit 5b075a4 into v12 Mar 13, 2026
8 of 9 checks passed
@balzss balzss deleted the INSTUI-4815-toggle-details-rework2 branch March 13, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants