Migration to std::make_unique C++17 (more safe) in all scope project#785
Open
GermanAizek wants to merge 1 commit intointel:masterfrom
Open
Migration to std::make_unique C++17 (more safe) in all scope project#785GermanAizek wants to merge 1 commit intointel:masterfrom
GermanAizek wants to merge 1 commit intointel:masterfrom
Conversation
Contributor
|
@GermanAizek please short the link in commit msg, not to exceed 80 characters in commit msg line |
7b1272e to
5fdb97a
Compare
Contributor
Author
Fix it 5fdb97a |
Contributor
|
Now, since we have 2025 please update year in copyright header in modified files |
Signed-off-by: Semenov Herman (Семенов Герман) <GermanAizek@yandex.ru>
5fdb97a to
87d9e25
Compare
Contributor
Author
fixed in this 87d9e25 |
Comment on lines
+917
to
+919
| auto allocPrivateData = std::make_unique<char>(queryResourceInfoFromNtHandle.TotalPrivateDriverDataSize); | ||
| auto resPrivateData = std::make_unique<char>(queryResourceInfoFromNtHandle.ResourcePrivateDriverDataSize); | ||
| auto resPrivateRuntimeData = std::make_unique<char>(queryResourceInfoFromNtHandle.PrivateRuntimeDataSize); |
Contributor
There was a problem hiding this comment.
Suggested change
| auto allocPrivateData = std::make_unique<char>(queryResourceInfoFromNtHandle.TotalPrivateDriverDataSize); | |
| auto resPrivateData = std::make_unique<char>(queryResourceInfoFromNtHandle.ResourcePrivateDriverDataSize); | |
| auto resPrivateRuntimeData = std::make_unique<char>(queryResourceInfoFromNtHandle.PrivateRuntimeDataSize); | |
| auto allocPrivateData = std::make_unique<char[]>(queryResourceInfoFromNtHandle.TotalPrivateDriverDataSize); | |
| auto resPrivateData = std::make_unique<char[]>(queryResourceInfoFromNtHandle.ResourcePrivateDriverDataSize); | |
| auto resPrivateRuntimeData = std::make_unique<char[]>(queryResourceInfoFromNtHandle.PrivateRuntimeDataSize); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@MichalMrozek,
Reference: https://stackoverflow.com/questions/22571202/differences-between-stdmake-unique-and-stdunique-ptr-with-new